Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add qodana CI checks (do not merge, PR for research) #128

Closed
wants to merge 6 commits into from
Closed

Add qodana CI checks (do not merge, PR for research) #128

wants to merge 6 commits into from

Conversation

qodana-cloud[bot]
Copy link

@qodana-cloud qodana-cloud bot commented Oct 31, 2024

Adds qodana.yaml and GitHub workflow file that runs Qodana static analysis on each pull request.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jinek jinek changed the title Add qodana CI checks Add qodana CI checks (do not merge, PR for research) Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Qodana for .NET

1448 new problems were found

Inspection name Severity Problems
XML highlighting 🔴 Failure 6
Redundant cast 🔶 Warning 175
Redundant arithmetic overflow checking context 🔶 Warning 139
Unused parameter (private accessibility) 🔶 Warning 74
Missing grid column/row setter for non-first child 🔶 Warning 14
Redundant namespace alias 🔶 Warning 12
Namespace does not correspond to file location 🔶 Warning 9
Possible 'System.NullReferenceException' 🔶 Warning 9
Unresolved binding path when DataContext is known 🔶 Warning 7
Parameter hides member 🔶 Warning 5
Overridden property 🔶 Warning 4
Member hides static member from outer class 🔶 Warning 4
The pattern is redundant, it does not produce any runtime checks 🔶 Warning 4
Type member is never used (private accessibility) 🔶 Warning 4
Access to a static member of a type via a derived type 🔶 Warning 3
Redundant using directive 🔶 Warning 3
Unknown property 🔶 Warning 2
Overriding property 🔶 Warning 2
Redundant name qualifier 🔶 Warning 2
Unassigned readonly field 🔶 Warning 2
Possible 'null' assignment to non-nullable entity 🔶 Warning 1
Deprecated property 🔶 Warning 1
Redundant property 🔶 Warning 1
Empty constructor 🔶 Warning 1
Invalid XML documentation comment 🔶 Warning 1
Non-accessed field (private accessibility) 🔶 Warning 1
Private field can be converted into local variable 🔶 Warning 1
Type member is never used (non-private accessibility) ◽️ Notice 267
Unresolved binding path when DataContext is unknown ◽️ Notice 81
Adjust modifiers declaration order ◽️ Notice 72
Member can be made private (non-private accessibility) ◽️ Notice 60
Add/remove 'this.' qualifier ◽️ Notice 36
Use collection expression syntax ◽️ Notice 36
Type is never used (non-private accessibility) ◽️ Notice 32
Invert 'if' statement to reduce nesting ◽️ Notice 29
Use explicit or implicit modifier definition for type members ◽️ Notice 27
Remove redundant parentheses ◽️ Notice 24
Convert constructor into primary constructor ◽️ Notice 19
Use preferred 'var' style (when type is simple) ◽️ Notice 18
Use preferred style of 'new' expression when created type is evident ◽️ Notice 17
Convert local variable or field into constant (private accessibility) ◽️ Notice 14
Redundant empty argument list on object creation expression ◽️ Notice 14
Method return value is never used (non-private accessibility) ◽️ Notice 14
Convert 'if' statement into 'switch' ◽️ Notice 12
'if-return' statement can be rewritten as 'return' statement ◽️ Notice 11
Use preferred style for trailing comma before new line in multiline lists ◽️ Notice 10
Use preferred body style (convert into property, indexer, or event with preferred body style) ◽️ Notice 9
Class is never instantiated (non-private accessibility) ◽️ Notice 8
Field can be made readonly (private accessibility) ◽️ Notice 8
RoslynAnalyzers Avoid constant arrays as arguments ◽️ Notice 7
Convert into 'using' declaration ◽️ Notice 7
Use object or collection initializer when possible ◽️ Notice 7
Add/remove qualifier for static members ◽️ Notice 6
Unassigned field (non-private accessibility) ◽️ Notice 6
Convert 'as' expression type check and the following null check into pattern matching ◽️ Notice 6
Auto-property can be made get-only (non-private accessibility) ◽️ Notice 5
Use preferred 'var' style (for built-in types) ◽️ Notice 5
Use string interpolation expression ◽️ Notice 5
Use preferred argument style for literal values ◽️ Notice 4
Merge null/pattern/value checks into 'or'/'and' patterns ◽️ Notice 4
Parameter can be declared with the base type ◽️ Notice 4
Convert into 'await using' statement or declaration ◽️ Notice 4
Replace if statement with null-propagating code ◽️ Notice 4
RoslynAnalyzers Mark members as static ◽️ Notice 3
Class with virtual (overridable) members never inherited (non-private accessibility) ◽️ Notice 3
Overlapping sections ◽️ Notice 3
Field can be made readonly (non-private accessibility) ◽️ Notice 3
Inline 'out' variable declaration ◽️ Notice 3
Member can be made static (shared) (non-private accessibility) ◽️ Notice 3
Type check and casts can be merged ◽️ Notice 3
Property can be made init-only (non-private accessibility) ◽️ Notice 3
Redundant type declaration body ◽️ Notice 3
Redundant verbatim string prefix ◽️ Notice 3
Use preferred argument style for string literal values ◽️ Notice 2
RoslynAnalyzers Use char overload ◽️ Notice 2
'if' statement can be rewritten as '?:' expression ◽️ Notice 2
Convert property into auto-property ◽️ Notice 2
Convert property into auto-property (when possible) ◽️ Notice 2
Member can be made static (shared) (private accessibility) ◽️ Notice 2
Merge null/pattern checks into complex pattern ◽️ Notice 2
Redundant semicolon after type or namespace declaration ◽️ Notice 2
Some values of the enum are not processed inside 'switch' statement and are handled via default section ◽️ Notice 2
Auto-property can be made get-only (private accessibility) ◽️ Notice 1
Replace built-in type reference with a CLR type name or a keyword ◽️ Notice 1
RoslynAnalyzers Use concrete types when possible for improved performance ◽️ Notice 1
RoslynAnalyzers Instantiate argument exceptions correctly ◽️ Notice 1
Dictionary lookup can be simplified with 'GetValueOrDefault' ◽️ Notice 1
Convert constructor into member initializers ◽️ Notice 1
'if' statement can be rewritten as '??=' assignment ◽️ Notice 1
Replace 'switch' statement with 'switch' expression ◽️ Notice 1
Loop can be converted into LINQ-expression ◽️ Notice 1
Merge conditional ?: expression into conditional access ◽️ Notice 1
Merge negated null/pattern checks into complex pattern ◽️ Notice 1
Merge nested property patterns ◽️ Notice 1
Method supports cancellation ◽️ Notice 1
Non-accessed field (non-private accessibility) ◽️ Notice 1
Parameter output value is always discarded (non-private accessibility) ◽️ Notice 1
Redundant 'else' keyword ◽️ Notice 1
Replace auto-property with computed property ◽️ Notice 1
Return type can be IEnumerable<T> (non-private accessibility) ◽️ Notice 1
RoslynAnalyzers Use 'LibraryImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time ◽️ Notice 1
Unused parameter (non-private accessibility) ◽️ Notice 1
Grid columns/rows definitions can be converted to attribute ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 58 dependencies

Third-party software list

This page lists the third-party software dependencies used in Consolonia

Dependency Version Licenses
Avalonia.Angle.Windows.Natives 2.1.22045.20230930 BSD-3-Clause
Avalonia.Controls.ColorPicker 11.2.0 MIT
Avalonia.Controls.ColorPicker 11.2.1 MIT
Avalonia.Controls.DataGrid 11.2.1 MIT
Avalonia.Controls.ItemsRepeater 11.1.4 MIT
Avalonia.Desktop 11.2.1 MIT
Avalonia.Diagnostics 11.2.0 MIT
Avalonia.Diagnostics 11.2.1 MIT
Avalonia.Fonts.Inter 11.2.1 MIT
Avalonia.FreeDesktop 11.2.1 MIT
Avalonia.Markup.Xaml.Loader 11.2.1 MIT
Avalonia.Native 11.2.1 MIT
Avalonia.ReactiveUI 11.2.1 MIT
Avalonia.Remote.Protocol 11.2.1 MIT
Avalonia.Themes.Fluent 11.2.1 MIT
Avalonia.Themes.Simple 11.2.0 MIT
Avalonia.Themes.Simple 11.2.1 MIT
Avalonia.Win32 11.2.1 MIT
Avalonia.X11 11.2.1 MIT
Avalonia 11.2.1 MIT
BlazorBindingsAvalonia.Core 0.1.2 MIT
BlazorBindingsAvalonia 0.1.2 MIT
CommunityToolkit.Mvvm 8.3.2 MIT
DynamicData 8.4.1 MIT
HarfBuzzSharp.NativeAssets.Linux 7.3.0.2 MIT
HarfBuzzSharp.NativeAssets.WebAssembly 7.3.0.3-preview.2.2 MIT
HarfBuzzSharp.NativeAssets.Win32 7.3.0.2 MIT
HarfBuzzSharp.NativeAssets.macOS 7.3.0.2 MIT
HarfBuzzSharp 7.3.0.2 MIT
MicroCom.Runtime 0.11.0 MIT
Microsoft.AspNetCore.Authorization 8.0.1 MIT
Microsoft.AspNetCore.Components.Analyzers 8.0.1 MIT
Microsoft.AspNetCore.Components 8.0.1 MIT
Microsoft.AspNetCore.Metadata 8.0.1 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 8.0.0 MIT
Microsoft.Extensions.DependencyInjection 8.0.0 MIT
Microsoft.Extensions.Logging.Abstractions 8.0.0 MIT
Microsoft.Extensions.Logging 8.0.0 MIT
Microsoft.Extensions.Options 8.0.1 MIT
Microsoft.Extensions.Primitives 8.0.0 MIT
Microsoft.NETCore.Platforms 1.1.0 MIT
NETStandard.Library 2.0.0 MIT
NUnit 3.13.1 MIT
zlib-acknowledgement
Newtonsoft.Json 13.0.3 MIT
ReactiveUI 20.1.1 MIT
SkiaSharp.NativeAssets.Linux.NoDependencies 2.88.8 MIT
SkiaSharp.NativeAssets.Linux 2.88.8 MIT
SkiaSharp.NativeAssets.WebAssembly 2.88.8 MIT
SkiaSharp.NativeAssets.Win32 2.88.8 MIT
SkiaSharp.NativeAssets.macOS 2.88.8 MIT
SkiaSharp 2.88.8 MIT
Splat 15.1.1 MIT
System.ComponentModel.Annotations 5.0.0 MIT
System.IO.Pipelines 8.0.0 MIT
System.Reactive 6.0.1 MIT
Tmds.DBus.Protocol 0.20.0 MIT
Unicode.net 2.0.0 MIT
Wcwidth 2.0.0 MIT
Contact Qodana team

Contact us at [email protected]

@jinek
Copy link
Owner

jinek commented Dec 13, 2024

@tomlm I'm not sure I find this useful. Inline comments by Resharper seem easier to go. I'm thinking to abandon this PR.

@jinek jinek closed this Dec 15, 2024
@jinek jinek added enhancement New feature or request wontfix This will not be worked on CI low priority labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI enhancement New feature or request low priority wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinek @qodana-bot